counsel.el (counsel-org-goto--get-headlines): Fix point-min bug #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outline-next-heading was always called once before starting the processing of the headlines, which resulted in the first headline to be excluded from the list if it was located at the very top of the file i.e. at point-min. The fixed function now checks if point is already on a heading and only calls outline-next-heading if this is not the case before starting the processing of the headlines.
|
Thanks. |
abo-abo
reviewed
May 17, 2017
| @@ -2386,7 +2389,8 @@ to custom." | |||
| (when (eq counsel-org-goto-display-style 'headline) | |||
| (setq name (concat (make-string level ?*) " " name))) | |||
| (setq name (counsel-org-goto--add-face name level)))) | |||
| (push `(,name . ,(point-marker)) entries))) | |||
| (push `(,name . ,(point-marker)) entries)) | |||
There was a problem hiding this comment.
That is correct, I'll simplify it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
outline-next-headingwas always called once before starting the processing of the headlines, which resulted in the first headline to be excluded from the list if it was located at the very top of the file i.e. at(point-min).The fixed function now checks if point is already on a heading and only calls
outline-next-headingif this is not the case before starting the processing of the headlines.