Various housekeeping #1704
Merged
Various housekeeping #1704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basil-conto
force-pushed
the
blc/housekeeping
branch
2 times, most recently
from
82f5cfb
to
871407d
Compare
(counsel--unicode-names): Do allocate candidates twice. (counsel-unicode-char): Reorder ivy-read args.
(counsel-describe-symbol-history): Reword docstring.
(counsel-unquote-regex-parens): Simplify.
(ivy-completing-read, ivy--filter, ivy--buffer-list): Replace assoc with assq.
counsel.el (counsel-git-change-worktree-action) (counsel-org-agenda-headlines--candidates): ivy.el (ivy-push-view): doc/ivy-ox.el (ivy-info-dir): Replace calls to buffer-file-name with its value.
(ivy--parent-dir): New function (ivy-backward-delete-char, ivy-backward-kill-word) (ivy--reset-state): Use it.
Reduce nesting of conditionals.
Flatten nested or-let-cond structure.
Document return value format and reformat amx-cache transformation. Re: abo-abo#1613, abo-abo#1614, abo-abo#1615
Do not let-bind this-command as per "(elisp) Command Loop Info".
(ivy--directory-done, ivy--reset-state): Replace cl-delete-duplicates with delete-dups.
counsel.el (counsel-irony-callback, counsel-git-stash) (counsel-find-file-move, counsel-find-file, counsel-org-goto-all) (counsel-org-file, counsel-semantic): ivy.el (ivy-thing-at-point, ivy-alt-done, ivy--sorted-files) (ivy--reset-state, ivy-completing-read, ivy--exhibit) (ivy-switch-buffer-other-window): swiper.el (swiper-multi, swiper-all): #'-quote function symbols.
ivy.el: Declare inhibit-message before its first use. Declare Info-read-node-name-1. swiper.el: Declare inhibit-message for Emacs 24.
counsel.el (counsel-imenu-categorize-functions): Simplify.
No need to handle delete-selection-mode here, and this also pacifies the Emacs 24 byte-compiler.
basil-conto
force-pushed
the
blc/housekeeping
branch
from
871407d
to
b5e8556
Compare
abo-abo
reviewed
Aug 8, 2018
ivy.el
Outdated
| @@ -3457,26 +3457,24 @@ CANDS is a list of strings." | |||
| (let (virtual-buffers) | |||
| (bookmark-maybe-load-default-file) | |||
| (dolist (head (append | |||
| (copy-sequence recentf-list) | |||
There was a problem hiding this comment.
AFAICT no, given the call to append.
abo-abo
reviewed
Aug 8, 2018
| @@ -61,37 +61,19 @@ N is obtained from `counsel-more-chars-alist'." | |||
| (list "" (format "%d chars more" diff))))) | |||
|
|
|||
| (defun counsel-unquote-regex-parens (str) | |||
| "Unquote regex parenthesis in STR." | |||
There was a problem hiding this comment.
Would be nice to add some tests for this.
There was a problem hiding this comment.
I wrote this commit a few moons ago, and made sure to test that my refactor was equivalent at the time, but I stupidly didn't commit the tests. Sorry, will do so in a follow-up PR.
|
Thanks! |
basil-conto
added a commit
to basil-conto/swiper
that referenced
this pull request
Aug 9, 2018
counsel.el (counsel-unquote-regex-parens): Improve error message for case that should never happen(TM). ivy-test.el (counsel-unquote-regex-parens): Test cons argument and all supported parentheses. Re: abo-abo#1704
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm sorry about the mega-dump, but each commit in turn should be pretty straight-forward.