Allow counsel-yank-pop after point #1762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(counsel-yank-pop-action, counsel-yank-pop): Do not bother setting ivy-completion-beg and ivy-completion-end. They do not seem to be used anywhere, and their relative ordering might be reversed following C-u C-y. Re: abo-abo#1761
This is in preparation for future work in this area.
(counsel-yank-pop-after-point): New user option. (counsel-yank-pop-action): Use it to determine whether to exchange point and mark. (counsel-yank-pop): Repurpose plain prefix arguments like C-u for temporarily toggling the new counsel-yank-pop-after-point. Re: abo-abo#884 Closes abo-abo#1761
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1761 for precedents. I have tried to make each commit atomic, so reviewing them in turn should be easiest.
N.B. The last commit introduces a user-visible breaking change. Previously,
counsel-yank-popinterpreted any prefix argument as a number, e.g. C-u and M-4 both yanked the 4th previous kill. Now, plain prefix arguments like C-u are interpreted similarly to vanillayank, in that they temporarily toggle the newcounsel-yank-pop-after-point. The following are my justifications for this:yank.counsel-yank-pop, as it's simultaneously a very specific kill ring position, but also large enough a number to be relatively arbitrary/obscure.counsel-yank-poprely on the exponential nature of repeated C-u invocations to quickly yank the 16th, 64th, etc. kill.Re: #884
Cc: @Custodia, @dieggsy