Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel-git-grep-switch-cmd does not set enable-recursive-minibuffers #2720

Open
brownts opened this issue Nov 10, 2020 · 0 comments · May be fixed by #2723
Open

counsel-git-grep-switch-cmd does not set enable-recursive-minibuffers #2720

brownts opened this issue Nov 10, 2020 · 0 comments · May be fixed by #2723

Comments

@brownts
Copy link
Contributor

brownts commented Nov 10, 2020

Most/all? counsel commands which can be launched from the minibuffer appear to locally set enable-recursive-minibuffers to avoid a "Command attempted to use minibuffer while in minibuffer" error (e.g., counsel-cd). However, it appears that counsel-git-grep-switch-cmd does not locally set this variable. Thus, when the Emacs configuration does not enable recursive minibuffers, this will prevent the custom git-grep command functionality from working successfully.

Steps to reproduce:

  1. Start Emacs via the repository make plain command
  2. Clear enable-recursive-minibuffers: M-: (setq enable-recursive-minibuffers nil)
  3. Open ivy.el in buffer: C-x C-f ~/git/swiper/ivy.el
  4. Start a git-grep search: C-c j
  5. Attempt to switch git command: C-c C-m

Error "Command attempted to use minibuffer while in minibuffer" is displayed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant