Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

counsel-rg displays "1 more chars" even when rg has already started #3029

Open
bcc32 opened this issue Nov 21, 2023 · 1 comment · May be fixed by #3030
Open

counsel-rg displays "1 more chars" even when rg has already started #3029

bcc32 opened this issue Nov 21, 2023 · 1 comment · May be fixed by #3030

Comments

@bcc32
Copy link
Contributor

bcc32 commented Nov 21, 2023

I, and several users at my site, have observed the following confusing behavior with counsel-rg when the user types a query string quickly:

  1. The ++ marker to indicate that rg is still running is not displayed
  2. 1 chars more (or sometimes 2 chars more) is displayed despite the query string being long enough
  3. rg is running

This seems to happen when rg is running but just hasn't produced any results yet (or maybe never will, depending on the query string).

Eventually, when rg completes, the correct message "no matches found" is displayed. But counsel never displays the state where rg is still running.

Here's a screenshot of the bad state:

image

@kuba-orlik
Copy link

I'm experiencing a similar issue, but rg doesn't seem to ever start when getting enough characters

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants