Make counsel-imenu show functions as "Function: func". #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the missing category of functions for counsel-imenu.
The global function is display in "Function: func".
All the other contents will retain unchanged, e.g.
Package: pack
Variables: var
Import: pack
basil-conto
reviewed
May 17, 2018
| (functions (remove-if (lambda (x) (listp (cdr x))) items))) | ||
| (if functions | ||
| (append others `(("Function" ,@functions))) | ||
| items))) |
There was a problem hiding this comment.
The Swiper project uses cl-lib, not cl, so you should use the cl- namespace. You can also simplify this code a bit:
(defun counsel-imenu-categorize-functions (items)
"Categorize all the functions of imenu."
(let ((fns (cl-remove-if #'listp items :key #'cdr))
(others (cl-remove-if #'nlistp items :key #'cdr)))
(if fns
(nconc others `(("Function" ,@fns)))
items)))or even
(defun counsel-imenu-categorize-functions (items)
"Categorize all the functions of imenu."
(let ((fns (cl-remove-if #'listp items :key #'cdr)))
(if fns
(nconc (cl-remove-if #'nlistp items :key #'cdr)
`(("Function" ,@fns)))
items)))
|
Merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the missing category of functions for counsel-imenu.
The global function is display in
Function: func.All the other contents will retain unchanged, e.g.
Tested in
emacs-lisp-mode,c++modeandpython-mode.