Example code in documentation not running

[ndortega]

I'm trying to run the example code and was unable to circumvent this error: "the trait img_hash::HashImage is not implemented for image::DynamicImage". Could you look into this??

[abonander]

Type errors like this usually mean a version mismatch; the version of the image crate that you're using isn't the same version that img_hash is using (it needs updating pretty badly but that probably means yet another major version bump; don't go to 1.0 before your public dependencies, kids). Try using image = "0.13" in your Cargo.toml and see if it builds then.

[rasky]

Found this. Currently, img_hash requires image <= 0.13 in its Cargo.toml. Any reason for forcing this? It means it doesn't work with latest image version which is 0.19.

[abonander]

Not particularly, I just haven't updated it. In fact, on the 3-alpha branch I expanded the version range to include 0.19 and it works just fine.

I was slightly worried it would be a breaking change but that's only an issue if someone has image = "*" in their dependencies and runs cargo update, but that's not really img_hash's problem.

I'll update this with a minor release, since it's a backwards-compatible change to the public API.

[rasky]

FWIW, image = * is the suggested way to add the image crate (see their README). I suggest that you find a more future proof way to declare the dependency or you’ll have to track upstream even if they don’t break the API.

[abonander]

That's really not my problem. It's the user's responsibility to pin the version they've built against or accept breakages on arbitrary upgrades. Cargo should really be warning about wildcard dependency versions. My goal with img_hash is to provide as wide of a dependency range compatibility as possible.

[abonander]

Published 2.1.0