parallelize rubocop and normal tests for speed and clarity on what broke #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
(test errors are fixed with #165) |
|
@abonas rebased this one ... should be green now |
|
how much time does this save? the gem's tests shouldn't take too long to run in the first place. |
|
takes it from 45s to 30s for ruby 2.0-2.2 ... but I think the main win is visibility, it's now obvious that rubocop failed and not the tests itself |
|
I don't have any objections/concerns regarding this change. |
|
I am definitely in favor of the |
|
@simon3z yes, I also had thoughts about the Rakefile. |
|
updated Rakefile |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@abonas