Update callback.ts - support response type 'code' #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I use gravitee am with the below configurations (at end).
response_type 'code' will not work because callback is always expecting access_token in params.
After login, user will be redirected to the callback url with code in params.
That code will be used to obtain an access token.
I have updated this callback to be able to handle tokens.
BIG THANK YOU FOR THIS MODULE. You have saved me a lot of time.
-----
openidConnect: {
addPlugin: true,
op: {
issuer: 'https://MY_DOMAIN/am/oidc',
clientId: 'CLIENT-ID-XXXXXX',
clientSecret: 'CLIENT-SECRET-XXXXXX',
callbackUrl: 'https://MY_DOMAIN/oidc/callback',
scope: 'openid profile email',
},
config: {
response_type: 'code',
secret: 'oidc._sessionid',
cookie: {},
cookieMaxAge: 24 * 60 * 60, // default one day
},
},
KhaledAlMana
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I use gravitee am with the below configurations (at end). response_type 'code' will not work because callback is always expecting access_token in params. After login, user will be redirected to the callback url with code in params. That code will be used to obtain an access token.
I have updated this callback to be able to handle tokens.
BIG THANK YOU FOR THIS MODULE. You have saved me a lot of time.
openidConnect: { addPlugin: true, op: { issuer: 'https://MY_DOMAIN/am/oidc', clientId: 'CLIENT-ID-XXXXXX', clientSecret: 'CLIENT-SECRET-XXXXXX', callbackUrl: 'https://MY_DOMAIN/oidc/callback', scope: 'openid profile email', }, config: { response_type: 'code', secret: 'oidc._sessionid', cookie: {}, cookieMaxAge: 24 * 60 * 60, // default one day }, },