Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cookie): cookie flags support and minor fixes #7

Merged
merged 4 commits into from Dec 13, 2022

Conversation

KhaledAlMana
Copy link
Collaborator

@KhaledAlMana KhaledAlMana commented Dec 12, 2022

Breaking changes

None

Changes

  • Support runtime configurations in playground (via .env)
  • fix response_types typo, changed to -> response_type
  • fix scopes was pilings up caused by:
    - defaults were always appended to configured scopes
    - openid was added 3 times (from defaults, configurations, and issueClient parameters)

UPDATE 1:

  • Added support for cookie flags and its documentation to be able to secure cookies if needed, with httpOnly, and secure flags or any other flags.

@KhaledAlMana KhaledAlMana changed the title Minor fixes feat(cookie): cookie flags support and minor fixes Dec 12, 2022
@aborn aborn merged commit 1dae091 into aborn:main Dec 13, 2022
@aborn
Copy link
Owner

aborn commented Dec 13, 2022

image

Get this error when pack.

@KhaledAlMana
Copy link
Collaborator Author

I will check now

@aborn
Copy link
Owner

aborn commented Dec 13, 2022

temporary solution define CookieSerializeOptions again:
https://github.com/aborn/nuxt-openid-connect/blob/main/src/module.ts

If you can find better solution, change it! Thanks.

@KhaledAlMana
Copy link
Collaborator Author

Yes, Thanks, I've checked it already.
Totally fine for the moment while I figure out the better solution.

@KhaledAlMana
Copy link
Collaborator Author

Currenlty your temp solution is the cleanest.
There are many ways, but not very clean. It will require a bit more time than expected.
I will try to take a deeper look into it another time.
Thanks for the fix, and the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants