Fixing issue found in IE9+ with change event dispatch

[dominicbarnes]

In my app, I discovered that in IE9 the change event would not fire as expected. Basically,
only a handler attached via onchange = function () { ... }; would work, all others such as
those bound via addEventListener would not fire at all.

After closer investigation, the condition used to test whether to use dispatchEvent or fireEvent
was not catching IE9+ correctly. (ie: typeof Event === "object") so I've changed this conditional
to hopefully be simpler and more accurate.

[abpetkov]

How does that change made in switchery.js gives us any value? You're correct IE9 has issues when trying to change the checkbox state via another element (e.g. button), but if you make this change on the change event you manually fire on button click, it would fix it. But it makes no difference to be in the main file. Here's a demo which doesn't work in IE9, but will work if using dispatchEvent in the if statement.

[dominicbarnes]

I'm not sure I follow your objection.

I was using switchery in another project and IE9 was not working correctly. IE9 reports the typeof as "object", instead of "function". But the check doesn't look necessary anyways, since the goal was to make sure we chose properly between dispatchEvent and fireEvent.

This fixes IE9, and continues to work for other browsers, unless you specifically know of something I've broken here?

[abpetkov]

I have no objection. I'm trying to understand what your problem was, since you haven't shared it and how does this solve it. I messed around with this and I don't see any difference with how it currently is. I understand it all, I just don't know the problem you came across. The only problem I found is the one I described above - button to change input state.

[dominicbarnes]

Check out this demo, you'll need to open the console.

In most browsers, both of those change events are fired. In IE9, only the one assigned via elem.onchange = function () { ... }; is fired.

[dominicbarnes]

In this demo, I've attached multiple handlers via elem.addEventListener("change", function () { ... });.

[abpetkov]

Seems legit. Thanks!