Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace System.Drawing with ImageSharp in Blogging module #10081

Closed
ebicoglu opened this issue Sep 20, 2021 · 1 comment · Fixed by #10494
Closed

Replace System.Drawing with ImageSharp in Blogging module #10081

ebicoglu opened this issue Sep 20, 2021 · 1 comment · Fixed by #10494
Assignees
@EngincanV
Labels
abp-module-blogging breaking change effort-2 enhancement
Milestone
5.0-preview

Comments

@ebicoglu
Copy link
Member

We are using System.Drawing library to validate images for Blog Module. See the reference -> https://github.com/abpframework/abp/blob/dev/modules/blogging/src/Volo.Blogging.Application/Volo.Blogging.Application.csproj#L14

After .NET6 Microsoft announces that  System.Drawing  library is being obsolete for non-Windows OS. See https://docs.microsoft.com/en-us/dotnet/api/system.drawing?view=net-5.0#remarks

We'll replace System.Drawing with https://github.com/SixLabors/ImageSharp as suggested in the Microsoft remarks.
@ebicoglu ebicoglu added this to the 5.0-final milestone Sep 20, 2021
@ebicoglu ebicoglu modified the milestones: 5.0-final, 5.0-preview Sep 20, 2021
@leonkosak
Copy link
Contributor

Interesting articles

https://devblogs.microsoft.com/dotnet/net-core-image-processing/
https://photosauce.net/blog/post/5-reasons-you-should-stop-using-systemdrawing-from-aspnet

@ebicoglu ebicoglu assigned EngincanV and unassigned berkansasmaz Oct 27, 2021
@EngincanV EngincanV mentioned this issue Nov 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@EngincanV EngincanV

Labels
abp-module-blogging breaking change effort-2 enhancement
Projects
None yet
Milestone
5.0-preview
Development

Successfully merging a pull request may close this issue.

Blogging: Replace System.Drawing with ImageSharp package abpframework/abp
4 participants
@ebicoglu @berkansasmaz @leonkosak @EngincanV