Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add social media register options to Register page #11504

Closed
hikalkan opened this issue Jan 30, 2022 · 4 comments · Fixed by #17406
Closed

Add social media register options to Register page #11504

hikalkan opened this issue Jan 30, 2022 · 4 comments · Fixed by #17406

Comments

@hikalkan
Copy link
Member

hikalkan commented Jan 30, 2022

Currently, only the login page has the social media (external) login options. However, sometimes we are directly sharing a link of the Register page to users (to register to the website), so they may miss the social login option. So, both of login and register pages should have social/external login possibility.

@dmeagor
Copy link

dmeagor commented Feb 3, 2022

Also once you've registered it's impossible to then login using SSO as you get an account already exists error.

Standard SSO flow is to match the SSO email address claim with an account on the system and log them in to that account. Is how it will work in 5.3-preview?

Another fairly critical option is to enforce SSO (disable basic login) once linked so that google/facebook/twitter 2FA cannot be bypassed using the login/password.

@lukebooroo
Copy link

I've just been looking at implementing the social logins for our app. I've run into the problem described above, plus these:

  1. If there are existing users with the email address of their google account, there's no way to switch their login method to an external provider.
  2. Email address is asked for in the registration process, shouldn't this be taken from the provider e.g. google

@dmeagor
Copy link

dmeagor commented Feb 3, 2022

This is how chargebee handle login when the email matches multiple accounts. (in their case they have a "test site" also)

Google SSO login...

image

@hikalkan hikalkan modified the milestones: 5.3-preview, 6.0-preview Apr 28, 2022
@hikalkan hikalkan self-assigned this Apr 28, 2022
@hikalkan hikalkan modified the milestones: 6.0-preview, 7.0-preview May 24, 2022
@hikalkan hikalkan modified the milestones: 7.0-preview, 7.1-preview Jul 21, 2022
@hikalkan hikalkan modified the milestones: 7.3-preview, 7.4-preview May 7, 2023
@hikalkan hikalkan modified the milestones: 7.4-preview, 8.0-preview Jun 4, 2023
@hikalkan hikalkan assigned maliming and unassigned hikalkan Aug 11, 2023
@hikalkan
Copy link
Member Author

@dmeagor and @lukebooroo thanks for your feature suggestions. However, they are out of scope for this issue. We will consider these separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants