Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit-Logging event enhancements #11982

Closed
gterdem opened this issue Mar 16, 2022 · 3 comments
Closed

Audit-Logging event enhancements #11982

gterdem opened this issue Mar 16, 2022 · 3 comments
Assignees
Labels

Comments

@gterdem
Copy link
Contributor

gterdem commented Mar 16, 2022

In distributed system cases where Audit-Logging needs to be written by using events instead of direct database connection, there is a huge overhaul about mapping AuditLogInfo to an Eto. We can simplify this process.

@Trojaner
Copy link
Contributor

Solves the issue I was just facing here.

While at it, can you make AuditLog and its property setters public in case we want to add custom audit logs like here?

@gterdem
Copy link
Contributor Author

gterdem commented Mar 17, 2022

Solves the issue I was just facing here.

While at it, can you make AuditLog and its property setters public in case we want to add custom audit logs like here?

Instead of adding property directly to AuditLog aggregate-root, I would suggest using ExtraPropertyDictionary. Do you have use cases where object-extension doesn't work for you?

I also made AuditLogInfo collections with public setters so it will be available to be mapped fully with extra properties.

@gterdem
Copy link
Contributor Author

gterdem commented Apr 14, 2022

This improvement is canceled. See #11983 (comment).

@gterdem gterdem closed this as completed Apr 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants