Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revision for CMS Kit Features naming #14733

Closed
hikalkan opened this issue Nov 18, 2022 · 0 comments · Fixed by #14755
Closed

Revision for CMS Kit Features naming #14733

hikalkan opened this issue Nov 18, 2022 · 0 comments · Fixed by #14755
Assignees
@malikmasis @enisn
Labels
abp-module-cms-kit effort-sm enhancement
Milestone
7.0-final

Comments

@hikalkan
Copy link
Member

image

  • Remove all "Enabled" and "Enable" words here. They are completely unnecessary.
  • Truly goup features. For example, there is no meaning to enable blog page without enabling the blogpost page. Blogging is a single feature and covers all blogging functionalities.
  • The feature definitions should depend on the related global features. If a related global feature is disabled, these features should not be available at all.
  • Write better descriptions for feature definitions. For example "Enable menu in the application" feels me like that if I disable that, tenants won't see any menu in the application. But actually, it is related to CMS Kit's dynamic menu system.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malikmasis malikmasis

@enisn enisn

Labels
abp-module-cms-kit effort-sm enhancement
Projects
None yet
Milestone
7.0-final
Development

Successfully merging a pull request may close this issue.

Revision for CMS Kit Features naming abpframework/abp
3 participants
@hikalkan @malikmasis @enisn