Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement IHasEntityVersion for some entities of some modules #15135

Closed
hikalkan opened this issue Dec 15, 2022 · 2 comments · Fixed by #15169
Closed

Implement IHasEntityVersion for some entities of some modules #15135

hikalkan opened this issue Dec 15, 2022 · 2 comments · Fixed by #15169
Assignees
Milestone

Comments

@hikalkan
Copy link
Member

hikalkan commented Dec 15, 2022

We will implement the new IHasEntityVersion interface for some of the entities in the application modules (and also their corresponding ETO classes). Both for open source and commercial modules.

Open Source Modules

CMS Kit

  • Page
  • Blog Post (only posts, not blogs)

Identity

  • IdentityUser
  • IdentityRole
  • OrganizationUnit

Tenant Management

  • Tenant

Commercial Modules

SaaS

  • Tenant
  • Edition
@JadynWong
Copy link
Contributor

I noticed that EntityVersion is of type int. EntityVersion will always be self-incrementing on updating. Would it be better to use the long type?

int.MaxValue: 2147483647
long.MaxValue: 9223372036854775807

int.MaxValue is enough to handle most types of business. Maybe I'm overthinking it and want to see what you think.

@malikmasis
Copy link
Contributor

I noticed that EntityVersion is of type int. EntityVersion will always be self-incrementing on updating. Would it be better to use the long type?

int.MaxValue: 2147483647
long.MaxValue: 9223372036854775807

int.MaxValue is enough to handle most types of business. Maybe I'm overthinking it and want to see what you think.

Hi,
That's right but I think the long type will be unnecessary for that. It doesn't seem possible to change the same line that many times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants