Is there any plan (Is it necessary?) to add specification signatures to the IReadOnlyBasicRepository interface

[colinin]

Is there an existing issue for this?

• I have searched the existing issues

Is your feature request related to a problem? Please describe the problem.

You can enhance the Specification query approach, making it easier for users to combine query results.

Describe the solution you'd like

For example:

Interface:

public interface IReadOnlyBasicRepository<TEntity> : IRepository where TEntity : class, IEntity
{
    // Added a specification list query api
    Task<List<TEntity>> GetListAsync(ISpecification<TEntity> specification, bool includeDetails = false, CancellationToken cancellationToken = default);

    // Added a specification paged list query api
    Task<List<TEntity>> GetPagedListAsync(ISpecification<TEntity> specification, bool includeDetails = false, string sorting = null, int skipCount = 0, int maxResultCount = 10, CancellationToken cancellationToken = default);

    // // Added a specification count query api
    Task<long> GetCountAsync(ISpecification<TEntity> specification, CancellationToken cancellationToken = default);
}

Implement:

public abstract class EfDemoRepository<TDbContext, TEntity> : 
    EfCoreRepository<TDbContext, TEntity>,
    IReadOnlyBasicRepository<TEntity> where TEntity : class, IEntity
{

    public ReadOnlyBasicRepository(
        IDbContextProvider<TDbContext> dbContextProvider)
        : base(dbContextProvider)
    {
    }

    public async virtual Task<List<TEntity>> GetListAsync(ISpecification<TEntity> specification, bool includeDetails = false, CancellationToken cancellationToken = default)
    {
        return await (await GetDbSetAsync())
            .Where(specification.ToExpression())
            .ToListAsync(GetCancellationToken(cancellationToken));
    }

    public async virtual Task<List<TEntity>> GetPagedListAsync(ISpecification<TEntity> specification, bool includeDetails = false, string sorting = null, int skipCount = 0, int maxResultCount = 10, CancellationToken cancellationToken = default)
    {
        sorting ??= "id";
        return await (await GetDbSetAsync())
            .Where(specification.ToExpression())
            .OrderBy(sorting)
            .PageBy(skipCount, maxResultCount)
            .ToListAsync(GetCancellationToken(cancellationToken));
    }

    public async virtual Task<long> GetCountAsync(ISpecification<TEntity> specification, CancellationToken cancellationToken = default)
    {
        return await (await GetDbSetAsync())
            .Where(specification.ToExpression())
            .LongCountAsync(GetCancellationToken(cancellationToken));
    }
}

Additional context

No response

[colinin]

Maybe it has a similar function

abp/framework/src/Volo.Abp.Ddd.Domain/Volo/Abp/Domain/Repositories/IReadOnlyRepository.cs

Lines 36 to 40 in 8236b83

	Task<List<TEntity>> GetListAsync(
	[NotNull] Expression<Func<TEntity, bool>> predicate,
	bool includeDetails = false,
	CancellationToken cancellationToken = default);
	}

[berkansasmaz]

What do you think about it @maliming?

[maliming]

We can consider doing this.