Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Angular Unit Tests didn't passed fully #15479

Open
mahmut-gundogdu opened this issue Jan 20, 2023 · 2 comments · Fixed by #17706
Open

Angular Unit Tests didn't passed fully #15479

mahmut-gundogdu opened this issue Jan 20, 2023 · 2 comments · Fixed by #17706
Assignees
@masumulu28
Labels
effort-md enhancement test ui-angular
Milestone
8.3-preview

Comments

@mahmut-gundogdu
Copy link
Contributor

mahmut-gundogdu commented Jan 20, 2023 •
edited

image
@mahmut-gundogdu mahmut-gundogdu added this to the 7.0-patch milestone Jan 20, 2023
@mahmut-gundogdu mahmut-gundogdu self-assigned this Jan 20, 2023
@mahmut-gundogdu mahmut-gundogdu mentioned this issue Jan 20, 2023
Merged
@mahmut-gundogdu mahmut-gundogdu added in-progress effort-0 No need to set an effort ui-angular and removed bug labels Feb 3, 2023
@mahmut-gundogdu mahmut-gundogdu mentioned this issue Feb 3, 2023
Merged
@rqx110
Copy link
Contributor

rqx110 commented Feb 6, 2023

@mahmut-gundogdu we also need remove OAuthService usage in home.component.spec.ts:
https://github.com/abpframework/abp/blob/dev/templates/app-nolayers/angular/src/app/home/home.component.spec.ts
https://github.com/abpframework/abp/blob/dev/templates/app/angular/src/app/home/home.component.spec.ts

@mahmut-gundogdu
Copy link
Contributor Author

@mahmut-gundogdu we also need remove OAuthService usage in home.component.spec.ts: https://github.com/abpframework/abp/blob/dev/templates/app-nolayers/angular/src/app/home/home.component.spec.ts https://github.com/abpframework/abp/blob/dev/templates/app/angular/src/app/home/home.component.spec.ts

Thank you for your comment. I will fix test issues piece by piece. I will fix home component changes too.

@mahmut-gundogdu mahmut-gundogdu modified the milestones: 7.0-patch, 7.1-final Feb 9, 2023
@hikalkan hikalkan modified the milestones: 7.1-final, 7.2-preview Mar 2, 2023
@hikalkan hikalkan modified the milestones: 7.2-preview, 7.2-final Apr 10, 2023
@hikalkan hikalkan modified the milestones: 7.2-final, 7.3-preview Apr 26, 2023
@mahmut-gundogdu mahmut-gundogdu changed the title Angular Test files in Templates didn't work. Angular Test files in Templates didn't pass fully. May 25, 2023
@mahmut-gundogdu mahmut-gundogdu changed the title Angular Test files in Templates didn't pass fully. Angular Unit Tests in Templates didn't passed fully. May 25, 2023
@mahmut-gundogdu mahmut-gundogdu modified the milestones: 7.3-preview, 7.3-final Jun 2, 2023
@mahmut-gundogdu mahmut-gundogdu modified the milestones: 7.3-final, 7.4-preview Jul 3, 2023
@hikalkan hikalkan removed the effort-0 No need to set an effort label Aug 18, 2023
@hikalkan hikalkan changed the title Angular Unit Tests in Templates didn't passed fully. Angular Unit Tests didn't passed fully Aug 18, 2023
@Sinan997 Sinan997 mentioned this issue Sep 22, 2023
Merged
@masumulu28 masumulu28 reopened this Sep 28, 2023
@masumulu28 masumulu28 modified the milestones: 8.1-preview, 8.2-preview Jan 28, 2024
@hikalkan hikalkan modified the milestones: 8.2-preview, 8.3-preview Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@masumulu28 masumulu28

Labels
effort-md enhancement test ui-angular
Projects
None yet
Milestone
8.3-preview
Development

Successfully merging a pull request may close this issue.

Angular Unit Tests fix some of them abpframework/abp
4 participants
@hikalkan @rqx110 @mahmut-gundogdu @masumulu28