Do we need IAvoidDuplicateCrossCuttingConcerns

[ahmetfarukulu]

Description

As far as I understand it controllers/pages don't use interceptions for performance issue but we're adding some unnecessary check

Analysis

As you notice apply method take object as parameter to avoid duplicate CCC and we give controller/page for that also we only use with filters but filters object(Controller/Page) never intercept by AbpInterception

• AbpFeaturePageFilter and AbpFeatureActionFilter avoid duplicate CCC and cheking from FeatureInterceptor
• GlobalFeaturePageFilter and GlobalFeatureActionFilter avoid duplicate CCC and cheking from GlobalFeatureInterceptor
• AbpAuditPageFilter and AbpAuditActionFilter avoid duplicate CCC and cheking from AuditingInterceptor

[maliming]

hi

We will try to ignore the Interceptors if there is a filter applied.

https://github.com/abpframework/abp/search?l=C%23&q=IsApplied

[ahmetfarukulu]

Hi,

We only apply for action/page filters and apply object is controller/page but we don't use interception for this types

In this issue reason for apply to not check twice but we can use AsyncLocal

public class NotifyOnExceptionInterceptor : AbpInterceptor, ITransientDependency
{
    private static readonly AsyncLocal<bool> IsExecute = new AsyncLocal<bool>();

    public NotifyOnExceptionInterceptor()
    {

    }

    public override async Task InterceptAsync(IAbpMethodInvocation invocation)
    {
        if (IsExecute.Value)
        {
            await invocation.ProceedAsync();
            return;
        }

        try
        {
            IsExecute.Value = true;
            await invocation.ProceedAsync();
        }
        catch (Exception e)
        {
            //Log exception
            throw;
        }
    }
}

[maliming]

private static readonly AsyncLocal<bool> IsExecute = new AsyncLocal<bool>();

I think this won't work. Did you try that?

[ahmetfarukulu]

It works important thing is interception start with Method1Async with this way every sub methods include the same context

[maliming]

Does it also work for multiple http requests?

[ahmetfarukulu]

Yes every http requests different scope

[maliming]

hi

Can you open a pr? then I will test it. Thanks

[ahmetfarukulu]

Hi @maliming

Filter avoid object and interception target object is different that's why IAvoidDuplicateCrossCuttingConcerns not work as expected. It check twice therefore these usings are unnecessary.

I think there is some confusion here BlogAdminAppService and BlogAdminController use same attributes(Authorize, RequiresFeature) in that case it check twice first action filter check after interception check(interception target object use BlogAdminAppService and action filter avoid object use BlogAdminController)

If we want to check once then it must be like TenantAppService and TenantController(Authorize check only TenantAppService)

In conclusion i think we can remove IAvoidDuplicateCrossCuttingConcerns and related things. Ofcourse this is not a complete solution it still check twice for prevent this we can check only on appservice side

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.