CmsKit - Not Found pages triggers infinite loop - ERR_TOO_MANY_REDIRECTS

[enisn]

Is there an existing issue for this?

• I have searched the existing issues

Description

as an example, browser tries to load the following file /__bundles/bootstrap.min.css.map and infinite redirection loop starts.

When I remove CmsKit Global Features;

GlobalFeatureManager.Instance.Modules.CmsKit(cmsKit =>
{
    //cmsKit.EnableAll();
});

everything works as expected and there is no problem

Reproduction Steps

No response

Expected behavior

No response

Actual behavior

No response

Regression?

No response

Known Workarounds

No response

Version

7.3.1

User Interface

Common (Default)

Database Provider

None/Others

Tiered or separate authentication server

None (Default)

Operation System

Windows (Default)

Other information

No response

[enisn]

Also, CmsKit tries to handle /Error page and redirection loop is triggered again

[enisn]

Found the problem:

abp/modules/cms-kit/src/Volo.CmsKit.Public.Web/CmsKitPublicWebModule.cs

Line 93 in 34835b5

options.Conventions.AddPageRoute("/Public/CmsKit/Pages/Index", PageConsts.UrlPrefix + "{slug:minlength(1)}");

The pattern above captures all paths that are not matched any route from routing, and also handles (Not Found - 404) too since it matches anything with min length 1.

Workaround

Changing pages url prefix in PreConfigureServices prevents handling everyting

public override void PreConfigureServices(ServiceConfigurationContext context)
{
    PageConsts.UrlPrefix = "pages/";
}

[enisn]

I think we can handle requests in a middleware instead registering all routes that starts with /

Like here:
https://github.com/volosoft/volo/blob/e5fae8331664a8e8596b499de02d0c6718a608a4/abp/cms-kit-pro/src/Volo.CmsKit.Pro.Public.Web/Middlewares/UrlShortingMiddleware.cs#L23

[enisn]

There is no quick fix without a breaking-change,
So, I'm closing this issue since it will be solved with #17319 in the 8.0 milestone.