Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abp-Password might be change with a common directive #18077

Closed
2 tasks
mahmut-gundogdu opened this issue Nov 7, 2023 · 1 comment · Fixed by #18112
Closed
2 tasks

Abp-Password might be change with a common directive #18077

mahmut-gundogdu opened this issue Nov 7, 2023 · 1 comment · Fixed by #18112
Assignees
@Sinan997
Labels
ui-angular ui-angular-modularization
Milestone
8.0-preview

Comments

@mahmut-gundogdu
Copy link
Contributor

mahmut-gundogdu commented Nov 7, 2023 •
edited by Sinan997

the code

https://github.com/abpframework/abp/blob/rel-7.4/npm/ng-packs/packages/theme-shared/src/lib/components/password/password.component.ts

If we implement the functionalty with directive

  • Replace the component with directive in ABP and ABP Commercial, Lepton X
  • Mark deprecated exists component (and remove in the future)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sinan997 Sinan997

Labels
ui-angular ui-angular-modularization
Projects
None yet
Milestone
8.0-preview
Development

Successfully merging a pull request may close this issue.

Deprecate abp-Password component instead use directive abpframework/abp
3 participants
@mahmut-gundogdu @ebicoglu @Sinan997