Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ABP CLI should make requests to the abp.io rather than GitHub #3404

Closed
ebicoglu opened this issue Mar 29, 2020 · 1 comment
Closed

ABP CLI should make requests to the abp.io rather than GitHub #3404

ebicoglu opened this issue Mar 29, 2020 · 1 comment
Assignees
@yekalkan
Labels
effort-0.5 invalid
Milestone
2.6

Comments

@ebicoglu
Copy link
Member

In the current case, CLI makes requests directly to GitHub.com.
And GitHub has a 5000 request rate limit in an hour.
It must make requests to abp.io and it should be cached.

Create GithubAppService and use caching.
Cache timeout must be timespan and configurable from appsetting.json.

image
@ebicoglu ebicoglu added this to the 2.5 milestone Mar 29, 2020
@ebicoglu ebicoglu modified the milestones: 2.5, 2.6 Apr 10, 2020
@yekalkan yekalkan removed this from the 2.6 milestone Apr 16, 2020
@yekalkan
Copy link
Member

Cli doesn't make requests to GitHub. I couldn't find any. Screenshot you provided is from Abp Suite.

@yekalkan yekalkan added this to the 2.6 milestone Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yekalkan yekalkan

Labels
effort-0.5 invalid
Projects
None yet
Milestone
2.6
Development

No branches or pull requests
2 participants
@yekalkan @ebicoglu