Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IOrganizationUnitRepository’s GetMembersCountAsync method miss "filter" argument #4302

Closed
JadynWong opened this issue Jun 10, 2020 · 1 comment · Fixed by #4304
Closed
Assignees
Milestone

Comments

@JadynWong
Copy link
Contributor

JadynWong commented Jun 10, 2020

Task<List<IdentityUser>> GetMembersAsync(
OrganizationUnit organizationUnit,
string sorting = null,
int maxResultCount = int.MaxValue,
int skipCount = 0,
string filter = null,
bool includeDetails = false,
CancellationToken cancellationToken = default
);
Task<int> GetMembersCountAsync(
OrganizationUnit organizationUnit,
CancellationToken cancellationToken = default
);

GetMembersAsync has filter parameter. But the GetMembersCountAsync method does not have filter parameter.

If the filter argument has a value, the total number of query will not match.

@realLiangshiwei
Copy link
Member

I will check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants