Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the "modal-dialog-scrollable" CSS class to the Abp-Modal tag helper #6369

Closed
jack-gaojz opened this issue Nov 27, 2020 · 6 comments · Fixed by #6659
Closed

Add the "modal-dialog-scrollable" CSS class to the Abp-Modal tag helper #6369

jack-gaojz opened this issue Nov 27, 2020 · 6 comments · Fixed by #6659

Comments

@jack-gaojz
Copy link
Contributor

Abp-Modal tag helper does not support the "modal-dialog-scrollable" feature. We should add the feature to the tag helper.
In the real environment, the feature is very useful.

I will like to create a pull request for this feature.
FYI.

@cotur
Copy link
Contributor

cotur commented Nov 27, 2020

It will be good feature for Modal tag helper.

We are waiting your PR. Thanks. :)

@jack-gaojz
Copy link
Contributor Author

It will be good feature for Modal tag helper.

We are waiting your PR. Thanks. :)

I am so sorry. I just want to contribute my codes change but always failed.
image
My steps as below:

  1. Clone the ABP source code to my local environment with Github desktop.
    image
  2. Open the VS 2019 create a new branch base on the dev branch.
    image
  3. Changes the code and push it into the new branch.
    image
    image
  4. Push it to the remote branch then failed.
    image
    image

@cotur
Copy link
Contributor

cotur commented Dec 5, 2020

You should fork the repository to your account, then push your changes on your forked repository. After that you can easily create pull request.

Here is a documentation for you: https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

@jack-gaojz
Copy link
Contributor Author

You should fork the repository to your account, then push your changes on your forked repository. After that you can easily create pull request.

Here is a documentation for you: https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

Thanks so much. :)

@jack-gaojz
Copy link
Contributor Author

You should fork the repository to your account, then push your changes on your forked repository. After that you can easily create pull request.

Here is a documentation for you: https://docs.github.com/en/free-pro-team@latest/github/collaborating-with-issues-and-pull-requests/creating-a-pull-request-from-a-fork

The PR link: #6659
FYI.

@cotur
Copy link
Contributor

cotur commented Dec 16, 2020

Hi @jack-gaojz,

I just saw your PR has been merged. Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants