Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All public repository methods should get CancellationToken #6971

Closed
hikalkan opened this issue Jan 3, 2021 · 0 comments · Fixed by #7359
Closed

All public repository methods should get CancellationToken #6971

hikalkan opened this issue Jan 3, 2021 · 0 comments · Fixed by #7359
Assignees
@realLiangshiwei
Labels
abp-framework effort-5 enhancement priority:normal
Milestone
4.3-preview

Comments

@hikalkan
Copy link
Member

hikalkan commented Jan 3, 2021

Currently, I see some methods hasn't. They should get CancellationToken (as optional parameter) just like others and use ICancellationTokenProvider if not provided by the user just like others.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@realLiangshiwei realLiangshiwei

Labels
abp-framework effort-5 enhancement priority:normal
Projects
None yet
Milestone
4.3-preview
Development

Successfully merging a pull request may close this issue.

Add CancellationToken optional parameter to all public repository methods abpframework/abp
2 participants
@hikalkan @realLiangshiwei