Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular: Use ng-bootstrap modal inside the abp modal component #7461

Closed
mehmet-erim opened this issue Jan 26, 2021 · 0 comments · Fixed by #7481
Closed

Angular: Use ng-bootstrap modal inside the abp modal component #7461

mehmet-erim opened this issue Jan 26, 2021 · 0 comments · Fixed by #7481

Comments

@mehmet-erim
Copy link
Contributor

We are recommended to use the ABP modal component to provide additional benefits like show the confirmation popup while closing the modal. ABP modal appends its own content to the body.
Recently, we have decided to use the ng-bootstrap modal component inside the abp-modal to achieve the best practices.

You can use the abp-modal as before. There is no breaking change however the inputs below are deprecated and will be removed in v5.0.

Deprecated inputs

  /**
   * @deprecated Use centered property of options input instead. To be deleted in v5.0.
   */
  @Input() centered = false;
  /**
   * @deprecated Use windowClass property of options input instead. To be deleted in v5.0.
   */
  @Input() modalClass = '';
  /**
   * @deprecated Use size property of options input instead. To be deleted in v5.0.
   */
  @Input() size: ModalSize = 'lg';

You should use the options input after the deprecation as following:

<abp-modal [options]="{centered: false, windowClass: 'my-custom-modal-class', size: 'md' }">
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant