Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS Kit - GetBySlugAsync method inconsistent behaviors #7803

Closed
ilkayilknur opened this issue Feb 22, 2021 · 1 comment
Closed

CMS Kit - GetBySlugAsync method inconsistent behaviors #7803

ilkayilknur opened this issue Feb 22, 2021 · 1 comment

Comments

@ilkayilknur
Copy link
Contributor

There is a GetBySlugAsync method inside BlogPost repositories. In the EF Core implementation, this method throws an exception if the record is not found. However, the Mongo DB implementation does not throw. Throwing an exception shouldn't be the job of the repositories. We need to move the checking and exception throwing mechanism to the domain layer.

@enisn
Copy link
Member

enisn commented Mar 1, 2021

It's already fixed while refactoring

@enisn enisn closed this as completed Mar 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants