Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement multitenancy on microservice demo #956

Closed
hikalkan opened this issue Apr 3, 2019 · 22 comments · Fixed by #3032
Closed

Implement multitenancy on microservice demo #956

hikalkan opened this issue Apr 3, 2019 · 22 comments · Fixed by #3032

Comments

@hikalkan
Copy link
Member

hikalkan commented Apr 3, 2019

No description provided.

@hikalkan hikalkan added this to the Backlog milestone Apr 3, 2019
@drony
Copy link

drony commented Jun 27, 2019

we have been waiting for this demo a long time. we need to make sure it works to start with abp

@hikalkan hikalkan modified the milestones: Backlog, 0.20.0 Jun 28, 2019
@hikalkan
Copy link
Member Author

it will work :) No problem on the infrastructure, but this is a complicated case. Need to test all possible flows and probably work on it a bit.

@drony
Copy link

drony commented Jun 30, 2019

To start new projects with this framework, I have to prove my boss that micro service and multi-tenant architecture are working flawlesly and unfortunately I don't have time to learn it, if it works this demo, I'll start without wasting time and start learning. I'm pretty sure a lot of people are waiting for this scenario:)

Best Regards

@hikalkan
Copy link
Member Author

hikalkan commented Jul 2, 2019

I'm pretty sure a lot of people are waiting for this scenario

I can agree on that, but can not drop currently prioritized works and immediately start to work on that, sorry :( I you don't have time, I can't provide a solution in a very short time.

@drony
Copy link

drony commented Jul 2, 2019

actually we don't expect a demo instantly. just put things right order. we'll wait :) thanks

@juicycleff
Copy link

I'm had some success doing this in my project, sorry I cant share the source code as its private. Maybe I can answer some questions. I'm not an expert in DotNet anymore, not programmed in it for 5 years plus, but I can share some insight

@hikalkan hikalkan self-assigned this Aug 18, 2019
@hikalkan hikalkan modified the milestones: 0.20, 0.21 Aug 26, 2019
@drony
Copy link

drony commented Aug 27, 2019

i'm very sad right now:( postponed this feature to v0.21

@hikalkan
Copy link
Member Author

Multenancy with microservice is complex. I don't say it is not important. It is hard and ABP will add a huge value on it. But we don't want to wait fundamental features and v1.0 release because of it. I hope this will be tested and stabilized before v1.0 release. If not, it will be a vert high priority issue after v1.0.

@hikalkan hikalkan modified the milestones: 0.21, 0.20 Sep 10, 2019
@la-digital
Copy link

Read ThreeMammals/Ocelot#1001 (comment) and was wondering if we might get multi-tenancy on the microservice demo by then :)?

@hikalkan
Copy link
Member Author

Hi all,

I am not able to continue to work on this. We should wait for Ocelot to support asp.net core 3.0. I hope it will be available in the next week, before we release ABP v1.0.

@hikalkan hikalkan modified the milestones: 0.22, 1.0 Oct 11, 2019
@hikalkan hikalkan modified the milestones: 1.0, 1.1 Oct 19, 2019
@la-digital
Copy link

Will we get this soon now that ocelot supports asp.net core 3.0?

@lockcd
Copy link

lockcd commented Nov 2, 2019

ocelot supports asp.net core 3.0
ocelot 13.8.0

@maliming
Copy link
Member

maliming commented Nov 3, 2019

@lockcd The abp microservices example has been upgraded ocelot 13.8.0

@pranavpatil19
Copy link

again it module move to next road map... hopefully done come in 1.2 roadmap

@hikalkan
Copy link
Member Author

hikalkan commented Dec 1, 2019

I will work on this just after v1.1 release, but I didn't want to delay the v1.1 release of the framework because of a sample application.

@pranavpatil19
Copy link

again it module move to next road map

@hikalkan
Copy link
Member Author

Yes, it moved again, sorry for it. But there was more significiant problems and you see that we needed to release an early 2.0 to fix the problems with some important changes.

This is a free and open source project. If this is important for you, please consider to send a PR. It would be appreciated.

@Tim1104
Copy link

Tim1104 commented Jan 9, 2020

I'm looking forward to this demo

@hikalkan hikalkan modified the milestones: 2.1, 2.2 Feb 19, 2020
@hikalkan
Copy link
Member Author

@pranavpatil19 I want to write before you: yes, it is moved again to the next milestone since we will release 2.1 tomorrow and didn't have time to work on this yet, sorry.

@pranavpatil19
Copy link

No issue @hikalkan. Take your time .

@hikalkan
Copy link
Member Author

hikalkan commented Mar 5, 2020

I am actively working on this on that branch: https://github.com/abpframework/abp/tree/ms-demo-multi-tenant

Changing milestone to 2.3, but milestone has no meaning with this sample, since it is not something released. I will continue to work on.

@alan-albuquerque
Copy link

alan-albuquerque commented Nov 6, 2020

Why are you guys talking like that if it's an open source project? These things takes time and if you really need it, go ahead and do it by yourself, then submit a pull request with it.

Anyway, thanks a lot @hikalkan for your work on it. It's a great framework that I'm really thinking to use in my project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants