add grant function on AuthService #15788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahmut-gundogdu
changed the title
| @@ -56,4 +65,6 @@ export interface IAuthService { | |||
| navigateToLogin(queryParams?: Params): void; | |||
|
|
|||
| login(params: LoginParams): Observable<any>; | |||
|
|
|||
| loginUsingGrant(grantType: string, parameters: object, headers?: HttpHeaders): Promise<AbstractModel>; | |||
There was a problem hiding this comment.
this method can be optional
There was a problem hiding this comment.
I think we can't mark as optional. That used on Abp commercial. I know the user have not use Oauth but we need that function for impersonate and link account.
mahmut-gundogdu
force-pushed
the
issue/15713_dd_grant_function_on_AuthService
branch
from
b370a11
to
bfe811c
Compare
muhammedaltug
approved these changes
Feb 27, 2023
muhammedaltug
deleted the
issue/15713_dd_grant_function_on_AuthService
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #15713 (write the related issue number if available)
TODO: Describe what this PR has changed, add screenshot or animated GIF if available, write if it is a breaking change, and how to fix the breaking changes for existing applications if so.
Checklist
How to test it?
no need to test on abp repo. it just abstraction