Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename package to keras_lmu #24

Merged
merged 1 commit into from Nov 6, 2020
Merged

Rename package to keras_lmu #24

merged 1 commit into from Nov 6, 2020

Conversation

drasmuss
Copy link
Member

@drasmuss drasmuss commented Nov 5, 2020

We've been referring to this package as "NengoLMU", which is kind of confusing because it doesn't really use Nengo at all. So we're changing the name to KerasLMU, which reflects the fact that this is a Keras-based implementation of LMUs. We're also renaming the package itself to align with this name (so people will now import keras_lmu and pip install keras-lmu). This is to clear the room for planned future implementations (e.g., a nengo-lmu which would actually be a Nengo-based LMU implementation). Although those packages don't exist yet, renaming the package itself at the same time as the "KerasLMU" name change seems appropriate.

Note that I'll be setting up a separate lmu package, so people will still be able to pip install lmu, and if they do that then import lmu will give them a deprecation message directing them to keras-lmu. In the future that lmu package will be used as a meta-package to install multiple LMU implementations.

@drasmuss drasmuss merged commit 6c7e562 into master Nov 6, 2020
@drasmuss drasmuss deleted the keras-lmu branch November 6, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants