Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relay's topology.json is generated with JSON syntax error #16

Closed
robinboening opened this issue Feb 15, 2021 · 4 comments
Closed

Relay's topology.json is generated with JSON syntax error #16

robinboening opened this issue Feb 15, 2021 · 4 comments

Comments

@robinboening
Copy link
Contributor

robinboening commented Feb 15, 2021

Starting the container throws this JSON parse error:

parse error: Expected separator between
values at line 1, column 225

I start the cardano node on the relay host with -e NODE_TOPOLOGY="xx.xxx.x.x:3000/1". The resulting topology.json file looks like this

$ root@cardano-relay-01:~# cat config/main-relay-01/topology.json
{
  ...,
  "Producers": [
    { "addr": "xx.xxx.x.x", "port": 3000, "valency": 1 }  { "addr": "relays-new.cardano-mainnet.iohk.io", "port": 3001, "valency": 2, "debug":"default fallback result" }
  ]
}

You can see its missing the comma inbetween the items in the array.

I looked up the place in the code where the NODE_TOPOLOGY is processed but it looks fine to me. I wasn't able to reproduce the issue by extracting and running the related code snippets.

The code in question is here: https://github.com/abracadaniel/cardano-node-docker/blob/master/scripts/init_config.py#L132

Any idea?

@robinboening
Copy link
Contributor Author

It turned out the init_config.py was a red herring. The bug is in the auto updater. I started the node with AUTO_TOPOLOGY="False" and the topology.json looks correct now.

I'll have a look into the updater.

@robinboening
Copy link
Contributor Author

@robinboening
Copy link
Contributor Author

I reported the bug at the guild-operators repo and it got fixed very quickly.

cardano-community/guild-operators#784

Closing this issue.

@abracadaniel
Copy link
Owner

Really awesome you got this fixed! And thanks a lot for your contributions, its super great! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants