Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inject localRoots in P2P topology when booting the node #60

Open
robinboening opened this issue Oct 26, 2023 · 0 comments
Open

inject localRoots in P2P topology when booting the node #60

robinboening opened this issue Oct 26, 2023 · 0 comments

Comments

@robinboening
Copy link
Contributor

robinboening commented Oct 26, 2023

Currently, when enabling P2P mode, the topology-p2p template is copied over and used as is. The template does not include any localRoots and therefore the relay running in P2P mode would not know about the block producer unless the information is added manually.

I suggest we allow to inject node information as we do with NODE_TOPOLOGY for non-P2P mode. Maybe we could use the same env variable for both modes.


Current template looks like this

{
  "localRoots": [
    {
      "accessPoints": [],
      "advertise": false,
      "valency": 1
    }
  ],
  "publicRoots": [
    {
      "accessPoints": [
        {
          "address": "relays-new.cardano-mainnet.iohk.io",
          "port": 3001
        }
      ],
      "advertise": false
    }
  ],
  "useLedgerAfterSlot": 84916732
}

but it when it is parsed by the cardano-node the final topology-p2p.json file should look like this

{
  "localRoots": [
    { "accessPoints": [
        { "address": "my-blockproducer.io", "port": 3000 }
      ]
      , "advertise": false
      , "valency": 1
    }
  ]
, "publicRoots" : [
    { "accessPoints": [
        { "address": "relays-new.cardano-mainnet.iohk.io", "port": 3001 }
      ]
      , "advertise": true
      , "valency": 1
    }
  ]
, "useLedgerAfterSlot": 0
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant