Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last TODO from code #369

Closed
abraham opened this issue Jun 16, 2015 · 2 comments
Closed

Remove last TODO from code #369

abraham opened this issue Jun 16, 2015 · 2 comments

Comments

@abraham
Copy link
Owner

abraham commented Jun 16, 2015

    private function encodeAppAuthorization($consumer)
    {
        // TODO: key and secret should be rfc 1738 encoded
        ...
    }
@abraham abraham added the Task label Jun 16, 2015
@mvasquezb
Copy link

Hello, I was looking up possible solutions to your issues that didn't require that much coding, since I'm still learning, and I noticed the rawurlencode function could do what you need, since rfc 3986 just updates 1738, right ?

@abraham
Copy link
Owner Author

abraham commented Jul 17, 2015

Reading through the comments of rawurlencode it seems like it has is not an exact match to rfc 1738. I haven't bothered to finish vetting it yet though as the Twitter docs say the values do not currently contain values that would get encoded.

@abraham abraham closed this as completed Jul 3, 2016
Repository owner locked and limited conversation to collaborators Dec 30, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants