Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue warning when queue gets too full #59

Open
5 of 6 tasks
abrahammurciano opened this issue Jan 23, 2022 · 0 comments · May be fixed by #61
Open
5 of 6 tasks

Issue warning when queue gets too full #59

abrahammurciano opened this issue Jan 23, 2022 · 0 comments · May be fixed by #61
Labels
enhancement New feature or request
Milestone

Comments

@abrahammurciano
Copy link
Owner

abrahammurciano commented Jan 23, 2022

Ideas/To do

  • Add parameter queue_warning_size (default 100?)
  • Replace Queue with a priority queue
  • Issue queue size warnings with higher priority
  • Make sure queue size warning is not issued too frequently
    • Maybe only once
    • Maybe once per queue fill up (e.g. once it gets full and a warning is issued, it won't be issued again until queue is half empty then fills up again)
      • bool issue_warning (init True) set to false after warning is issued and set to true when dequeueing and qsize() < queue_warning_size/2
      • when emitting, if qsize() > queue_warning_size and issue_warning, then enqueue log record with higher priority and set issue_warning to False
@abrahammurciano abrahammurciano added the enhancement New feature or request label Jan 23, 2022
@abrahammurciano abrahammurciano added this to the v1.1.0 milestone Jan 23, 2022
@abrahammurciano abrahammurciano linked a pull request Jan 24, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant