sessions: Clear doesn't return potential error

[yanniszark]

Clear function in sessions.go doesn't handle the return value of the clear function.

jeff/sessions.go

Line 225 in a6a878d

j.clear(ctx, s.Key)

[abraithwaite]

Great point! Do you think the preference would be to simply add an error return value to the signature of the function?

Technically I think that should backwards compatible, but it might throw a few vet errors for some users.

[yanniszark]

@abraithwaite I believe that changing the signature of an exported function breaks compatibility.
Thanks for catching that!

I see two possible solutions:

1. Break compatibility and bump the major version.
2. Introduce another function, with the correct functionality.

[abraithwaite]

I don't think breaking compatibility is completely out of the question here. It's certainly not a major breaking change and would likely not result in builds failing for most users. Furthermore, I haven't tagged this as 1.0.0 yet, so minor breaking changes are definitely not outside the realm of possibility. :-)

I'm leaning towards just adding an error onto the signature unless I can think of a strong reason not to.

[abraithwaite]

Fixed in #25