Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger dragenter before dragover #114

Merged
merged 3 commits into from Oct 20, 2019

Conversation

tmcw
Copy link
Contributor

@tmcw tmcw commented Oct 10, 2019

In our codebase, we rely on dragenter occurring before drop, and that's also the cycle that would be expected out of an actual user. This PR adds a dragenter event before it triggers drop.

@abramenal
Copy link
Owner

Hi @tmcw
Thanks for the contribution!
I would suggest to also add dragleave event just to keep it consistent in that case. Can you please do that here?
Also, all the handlers (and this particular as well) returns chainable cy object so please make it here as well.
After these changes come I'll release this with new plugin version.

@all-contributors add @tmcw for code

Repository owner deleted a comment from allcontributors bot Oct 11, 2019
@abramenal
Copy link
Owner

@all-contributors add @tmcw for code

@allcontributors
Copy link
Contributor

@abramenal

I've put up a pull request to add @tmcw! 🎉

@abramenal abramenal merged commit 4fdb09c into abramenal:master Oct 20, 2019
@abramenal
Copy link
Owner

@tmcw v3.4.0 containing this fix is out.
Thanks again for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants