Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.d.ts #170

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Update index.d.ts #170

merged 1 commit into from
Mar 23, 2020

Conversation

triqi
Copy link
Contributor

@triqi triqi commented Mar 23, 2020

Summary

This change will fix the Typescript error Property 'visit' does not exist on type 'cy & EventEmitter'. when importing cypress-file-upload.

Details

Typescript interface merging requires that the signature match the original interface definition.

## Summary

This change will fix the Typescript error `Property 'visit' does not exist on type 'cy & EventEmitter'.` when importing `cypress-file-upload`.

## Detailed description

Typescript interface merging requires that the signature match the original interface definition.
@abramenal
Copy link
Owner

Closes #167

@abramenal abramenal merged commit 622a287 into abramenal:master Mar 23, 2020
@abramenal
Copy link
Owner

@all-contributors add @triqi for code

@allcontributors
Copy link
Contributor

@abramenal

I've put up a pull request to add @triqi! 🎉

@abramenal
Copy link
Owner

@triqi thanks a lot for the contribution! Really appreciate that 🥂

@abramenal
Copy link
Owner

Released with v4.0.4

@triqi triqi deleted the patch-1 branch March 23, 2020 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants