You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using shadowContains suffers from most of the same issues as shadowFind (#25 and fixed in #26). The biggest issues is that it does not retry if the element is not immediately found. It also doesn't search the light DOM of custom elements. After researching the internals, Cypress only triggers its "retry" logic if a method returns a jquery collection. Using Cypress.$ to query the DOM fixes the issue. I plan on submitting a PR soon.
Desired behavior:
If the element is not found immediately, Cypress should retry until the timeout is reached.
Steps to reproduce: (app code and test code)
Try to use shadowContains on an element which is not immediately available. I can create a repo if need be - just let me know.
Versions
cypress@3.7.0
cypress-shadow-dom@1.2.1
The text was updated successfully, but these errors were encountered:
Current behavior:
Using
shadowContains
suffers from most of the same issues asshadowFind
(#25 and fixed in #26). The biggest issues is that it does not retry if the element is not immediately found. It also doesn't search the light DOM of custom elements. After researching the internals, Cypress only triggers its "retry" logic if a method returns a jquery collection. UsingCypress.$
to query the DOM fixes the issue. I plan on submitting a PR soon.Desired behavior:
If the element is not found immediately, Cypress should retry until the timeout is reached.
Steps to reproduce: (app code and test code)
Try to use
shadowContains
on an element which is not immediately available. I can create a repo if need be - just let me know.Versions
cypress@3.7.0
cypress-shadow-dom@1.2.1
The text was updated successfully, but these errors were encountered: