New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
via ferrata included in route #517
Comments
Originally reported in BRouter-Web und via_ferrata (OSM Communities / Deutschland (Germany)). |
Well, seems to be the normal, intended, "optimistic" behaviour of these profiles. And seems that Marcus /bikerouter is supressing the "unknown" value for tags Some time ago I also supressed them, between these 2 commits: and not much people complained about the missing "unkown"s. Except me of course, but I remember that was because of brouter-suspect-scanning that was mis-behaving. So I'm not sure what the best solution is. Supresing "unknown'"s for me still is a bad concept, because that can cause profiles to change their behaviour by just extending the lookup-table. Very bad from a QA perspective. I think the clean solution is to drop the "optimistic default" of these profiles. Maybe after 10 years the map improved in a way that this is not necceary anymore (we have a lot of similar discussion especially fpr highway=construction") |
In this special case we could exclude highway=unknown in all.brf |
But the same is true if "unknowns" are not suppressed? But I agree that changes in behavior are much less likely if "unknowns" are not suppressed.
I agree.
We should exclude
Personally, I would even add some sort of failsafe like this to the |
We have via ferrata already in the next lookups.dat from #458 |
Every current bike profile or the hiking profile is routing me over a via_ferrata part:
I can reproduce this with
https://brouter.de/brouter-web/#map=17/49.55046/11.52695/osm-mapnik-german_style&lonlats=11.524113,49.551227;11.527776,49.550559&profile=trekking-ignore-cr
even if I copy the profile from the instance bikerouter.de that doesn't do this:
https://bikerouter.de/#map=17/49.55142/11.52554/standard&lonlats=11.524052,49.551279;11.527789,49.550568&profile=trekking
I thought it was a problem of the web frontend, but @nrenner wrote that I should open this issue here, where the lookup.dat and the profiles are maintained.
The text was updated successfully, but these errors were encountered: