Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download view in portait #551

Open
afischerdev opened this issue May 12, 2023 · 4 comments
Open

Download view in portait #551

afischerdev opened this issue May 12, 2023 · 4 comments

Comments

@afischerdev
Copy link
Collaborator

Is it possible that BInstallerActivity not declared as forced landscape in BRouter AndroidManifest.xml ?

It is a bit annoying to have to change orientation to download BRouter files.
Doesn't the map work with portrait orientation like all other map apps?

@abrensch
Copy link
Owner

If you do that without being prepared for the hard way of really doing responsive Design, then this will Just Produce Bug Reports..

@zod
Copy link
Collaborator

zod commented May 12, 2023

The map view would work in portait but android recreates the view during after rotation and I'm not sure if we would recreate all required information.

@afischerdev
Copy link
Collaborator Author

We will see. It was just a user request that I didn't want to ignore

@devemux86
Copy link
Contributor

devemux86 commented May 12, 2023

android recreates the view during after rotation

This can be avoided with:

<activity
    android:name=".BInstallerActivity"
    android:configChanges="keyboard|keyboardHidden|navigation|orientation|screenLayout|screenSize|smallestScreenSize|uiMode"
    android:exported="true"
    android:launchMode="singleTask" />

The map is rotated without destroying the activity, example AndroidManifest.xml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants