Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"No right turn on red" relation is wrongly interpreted as a prohibited turn #572

Closed
tensleepslav25 opened this issue Jun 23, 2023 · 7 comments
Labels

Comments

@tensleepslav25
Copy link

tensleepslav25 commented Jun 23, 2023

A right turn from Cedar Street onto Worcester Street with a "no turn on red" sign (as seen in route link) is legal, however one must wait until the light turns green. I propose that restriction=no_right_turn_on_red and restriction=no_left_turn_on_red tags apply a standard traffic signal penalty, such as if the route were to continue straight.

Route link
Relation link

Edit: in the meantime, is there any way to customize the car-eco profile so that the above tags are simply ignored in terms of routing?

@tensleepslav25 tensleepslav25 changed the title "No right turn on red" relation is incorrectly interpreted as a prohibited turn "No right turn on red" relation is wrongly interpreted as a prohibited turn Jun 23, 2023
@abrensch
Copy link
Owner

abrensch commented Jul 1, 2023

Hi tensleepslav25,

ja the preprocessor just looks for "only_" and "no_" prefixes from the restriction tag.

There seem to be competing approaches on how to map "on_red" restrictions: https://wiki.openstreetmap.org/wiki/No_turn_on_red

Sure I can filter out the "on_red" restrictions during pre-processing.

But there's no way to do it on the profile-level.

@tensleepslav25
Copy link
Author

Thanks for the reply.

Filtering out "on_red" in pre-processing seems like the most sensible solution given the lack of consensus on tagging.

@quaelnix
Copy link
Collaborator

quaelnix commented Jul 2, 2023

The example mentioned in post #1 does not work for some reason. Here is one that does:

@tensleepslav25
Copy link
Author

tensleepslav25 commented Jul 2, 2023

Ah, I removed the relation from the original example as that turn is one I frequently use for routing. Thanks for finding another example and sorry for the confusion.

@quaelnix
Copy link
Collaborator

quaelnix commented Jul 2, 2023

What really catched me off guard is that you "removed the restriction" by removing the via member. ;-)

@quaelnix quaelnix added the bug label Jul 22, 2023
@Pengor
Copy link

Pengor commented Oct 23, 2023

Hi, looks like this was fixed in 1a2bb19 and was included in version 1.7.1? Should this issue be closed?

I happened upon this because this (former) limitation is mentioned in a couple of places on the OSM wiki:
https://wiki.openstreetmap.org/wiki/No_turn_on_red
https://wiki.openstreetmap.org/wiki/Tag:restriction%3Dno_right_turn_on_red
I'm happy to update those if the issue is indeed resolved.

@quaelnix
Copy link
Collaborator

Yes, this problem has been fixed. Thanks for the reminder!

PS: For some reason brouter.de is still running an older version of BRouter that does not yet include this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants