-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for node-tags in lookups.dat #685
Comments
Probably good to describe how a router should have these node tags as I do not really see how it should do that, I do not see how these tags make sense in node context. |
Well, the profile I created and use is also based on these parameters (obviously only the way-tags part). I'll give you the example of my profile for enduro motorcycles: one of the dynamic variables present are the skills. Based on the choice between beginner, intermediate, advanced and expert, roads that have one of these tags that I mentioned are either rewarded or penalized. If I had the possibility to extend it also to the node part, it would be more complete. If you need it, I can send you the profile I created, and you will realize that it is very useful. It will not be the precise and super complex profile like those that are found around created by professionals, but hey, it does its job. Obviously, I am always trying to improve it, and that's why I made this request even though I am a novice. |
Sorry my earlier reply was not 100% to the point, I know how point/node based costs work in a profile, even made some code to handle traffic signals. BRouter uses OpenStreetMap data and the wiki page for smoothness indicates it may not be used for nodes (See "Used on these elements") The pages for mtb:scale and surface indicate that they might be used on nodes but if you look at the taginfo data below you see the usage is minuscule with 0.2% and 0.4%. Two questions:
|
However, I also understand that adding and working for such low percentages might not make sense, but they make the calculation more precise, just the fact that compute excludes some node values makes the compute imprecise, I mean, if in my profile I insert the code to avoid all the "mtb:scale=3|4|5" values , I would like that the route will be as precise as possible and therefore the segments to avoid should be all those segments that present this tag but also all the segments that have the node with the same tag In any case, it is better to let the profile creator decide whether or not to use that node rather than not being able to use it at all. I would also like to add another request. Today I was thinking about my profile and its calculation limits, and I would need to add the waterway=stream tag, the seasonal=* key (all tags), and the intermittent=* key (all tags). This is because I want my profile to consider these tags and keys. This will be especially useful in areas like Sardinia, where some streams can be used for recreation. Considering the global rise in temperatures, this could also be useful in other areas where the phenomenon is occurring, as it is in Sardinia. For now, I have worked around the problem by adding an additional highway=path or track tag to the existing waterway key, but I'm not sure if this is the correct way to map. Thank you for your time and consideration. |
Hello LupinSun, 1- As Polyscias I do not think, it is a good idea to set a tag such as smoothness on a node: The cost resulting from a "bad smoothness" depends on the length of the segment .... (example: barrier=debris... that is currently supported by the brouter!) 2- What do you mean about "waterway=stream" |
Response in English:
For example, I mentioned the mtb:scale tag. If my code avoids certain mtb:scale values, I want both segments and nodes to be avoided in the compute. Otherwise, the calculation is inaccurate.
Enduro: https://it.wikiloc.com/percorsi-enduro/orgosolo-54285480 (I ride in this stream too) I hope this explanation is clear. Thank you for your time and consideration. Best regards, LupinSun |
Hello LupinSun, 1- Smoothness on Node or on Way: Your use case "ford": Other cases: " sometimes use certain tags on nodes instead of the way to indicate short sections ......"
2- Riding in river / stream I help by Brouter enhancements form my own usage and to promote the biking... on the standard ways! Regards |
I want to clarify that I don't want to be insistent, annoying, or anything else, but just to understand and improve this wonderful project, of which I am also a user. The tag ford=yes is mainly used in nodes https://taginfo.openstreetmap.org/keys/ford#overview only about 10% is used on ways so what you described is a small part of its usage and unfortunately I am mistakenly led to think that the tag smoothness is added on the node ford=yes which at this point turns out to be about 90% of its usage. |
Hi everyone,
I noticed that some mappers, including myself, sometimes use certain tags on nodes instead of the way to indicate short sections without splitting the segment. I wonder if it would be possible to add the smoothness, mtb:scale, mtb:scale:uphill and surface tag to the node-tags section in lookups.dat, as it is done for the way-tags section?
Thank you for your time and consideration.
The text was updated successfully, but these errors were encountered: