Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making build of tests/examples explicit #43

Closed
niclar opened this issue Mar 15, 2022 · 6 comments
Closed

Consider making build of tests/examples explicit #43

niclar opened this issue Mar 15, 2022 · 6 comments

Comments

@niclar
Copy link

niclar commented Mar 15, 2022

Tying to build an example. -The cmake installation target for morph seem to miss e.g. Visual.h, ScatterVisual.h

@sebjameswml
Copy link
Collaborator

This might have happened if you built and installed morphologica without first having installed the glfw library on your system. If the cmake process fails to find glfw, then a make install won't install Visual.h and all the other headers required for graphical programs. Here's the relevant section of the CMakeLists.txt: https://github.com/ABRG-Models/morphologica/blob/main/morph/CMakeLists.txt#L16

@sebjameswml
Copy link
Collaborator

I'm just trying to build standalone_examples/schnakenberg with an installed morphologica (installed into /usr/local/). There are one or two headers that are not installed - base64.h is one.

@sebjameswml
Copy link
Collaborator

I made sure that the Schnakenberg example in standalone_examples/ will compile against an installed morphologica now (see the most recent couple of commits). Let me know which example you're trying to build if you are still stuck.

@niclar
Copy link
Author

niclar commented Mar 15, 2022

@sebjameswml Yeah I tried building/installing morph in isolation omitting examples & tests.

-Can you maybe make dependencies and examples explicitly optional (from the top level cmake) or the morph cmake "standalone". I.e use FindModule for glfw there

(also tried HEAD / 3efe3ab)

https://github.com/ABRG-Models/morphologica/files/8254410/patch.diff.txt

@sebjameswml
Copy link
Collaborator

Making deps and examples explicitly optional is possible, so that it's a simple make && make install process (buildling all the tests and examples does take quite a while).

@sebjameswml sebjameswml changed the title installation target missing Visual.h, ScatterVisual.h Consider making build of tests/examples explicit Mar 16, 2022
@sebjameswml
Copy link
Collaborator

I don't think I'll change the build process. When you type make, you'll just get all the tests and examples compiled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants