extra parameter to item.task()?

[dooglus]

Hey, fancy seeing you here!

I'm just learning node.js and came across your semaphore.js. Looking at the code, I'm wondering why you're passing semaphore.leave to item.task, when item.task doesn't take any parameters.

Not doing so seems to work. Is this a better way to do things?

diff --git a/lib/semaphore.js b/lib/semaphore.js
index 534ec18..da50b13 100644
--- a/lib/semaphore.js
+++ b/lib/semaphore.js
@@ -25,7 +25,7 @@ module.exports = function(capacity) {
            }

            semaphore.current += item.n;
-           item.task(semaphore.leave);
+           item.task();
        },

        leave: function(n) {

[abrkn]

It can:

var sem = require('semaphore')()
sem.take(function(leave) {
    console.log('about to leave')
    leave()
})

[dooglus]

The one the user provides can, but the one you're calling can't:

item.task = function() { task(semaphore.leave); };

[...]

item.task(semaphore.leave);

You've replaced the user's task (which can take a parameter) with a new function that can't.

[abrkn]

I don't understand the issue. Submit a pull request if there is a bug.