Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature-request] option to have multiple kubel buffers (instances) #54

Open
d1egoaz opened this issue May 31, 2021 · 10 comments
Open

[feature-request] option to have multiple kubel buffers (instances) #54

d1egoaz opened this issue May 31, 2021 · 10 comments

Comments

@d1egoaz
Copy link
Contributor

d1egoaz commented May 31, 2021

It would be great if I can operate multiple kubel buffers/instances, each one with it's own context/namespace (buffer local variables?)

I usually work with multiple context/namespace combinations at the same time, however, this package only allows me to have only one active kubel context/namespace.

Thanks for this amazing package!

@abrochard
Copy link
Owner

Hi @d1egoaz ,
Thank you for your interest! This might be a tad complicated, and there's also a risk of sending kubectl commands to the wrong place if a bug happens. I agree it's a really nice feature though, so I will put it on the back burner for now and see if I can make some time for it in the future.
Just wanted to be upfront and let you know.
Best,

@d1egoaz
Copy link
Contributor Author

d1egoaz commented Jun 2, 2021

Hi @d1egoaz ,
Thank you for your interest! This might be a tad complicated, and there's also a risk of sending kubectl commands to the wrong place if a bug happens. I agree it's a really nice feature though, so I will put it on the back burner for now and see if I can make some time for it in the future.
Just wanted to be upfront and let you know.
Best,

Thank you! I might look to see if I can do it over the summer, while I learn more about Emacs-lisp

@d1egoaz
Copy link
Contributor Author

d1egoaz commented Jul 27, 2021

Hey @abrochard

I've finally got time to implement this, I started my own fork and added this and other stuff.

https://github.com/d1egoaz/kubel

Please let me know if this workflow is the interest of this community and I'd happily start sending the upstream PRs.

Feel free to test the fork first, and cherry pick the features that you think make sense to have here. No hard feelings if you think my workflow doesn't apply here 😆

@abrochard
Copy link
Owner

Hi @d1egoaz ,
This looks amazing. I'm very interested and I would love to see that merged. I saw you have quite a few interesting commits. The next steps are based on two questions:

  1. how can we safely bring these changes? I know I need to extend unit test coverage, but is there also a way to bring code change incrementally in small PRs?
  2. if this new workflow diverges a lot from the current user experience, how can we teach users about it or minimize discomfort?

@d1egoaz
Copy link
Contributor Author

d1egoaz commented Aug 20, 2021

how can we safely bring these changes? I know I need to extend unit test coverage, but is there also a way to bring code change incrementally in small PRs?

Sure, small PRs might be the best idea.

if this new workflow diverges a lot from the current user experience, how can we teach users about it or minimize discomfort?

Let's see if I can make things opt-in without making too many changes to current workflow.

@d1egoaz
Copy link
Contributor Author

d1egoaz commented Aug 25, 2021

@abrochard I added a PR for this, please let me know if you have more questions/comments/changes. etc. Thanks!

@abrochard
Copy link
Owner

@d1egoaz thank you! I just got back from PTO, gonna take a look asap and will probably have lots of comments.

@d1egoaz
Copy link
Contributor Author

d1egoaz commented Aug 27, 2021

@d1egoaz thank you! I just got back from PTO, gonna take a look asap and will probably have lots of comments.

Thanks. Take your time. I'm actually going to be on 🌴 until the end of next week.

@Kyrremann
Copy link
Contributor

how's it going with these changes?

@abrochard
Copy link
Owner

Hi @Kyrremann,
You can follow the progress at #57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants