Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing enum34 requirement for python versions <= 3.4 in setup.py #81

Closed
wants to merge 1 commit into from

Conversation

alexhagen
Copy link

Was running into error on Python3.6 and pip 18.1

error in absl-py setup command: 'install_requires' must be a string or list of strings containing valid project/version requirement specifiers; Expected version spec in enum34;python_version<='3.4' at ;python_version<='3.4'

Using the install_requires and extra_requires fixed my problems, and is ostensibly a better way to do this see reference here.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@alexhagen
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@rickeylev
Copy link
Contributor

Hi Alex,

Thanks for the PR, but I'm prepping a different fix.

btw, this is being trackd in #79
Please chime in with your OS, Python version, pip version, and setuptools version (see issue for commands on how to get these) if it isn't already listed there.

@rickeylev
Copy link
Contributor

Oh, and that bug also has a link to the upcoming fix that you can try; if it doesn't work for you, please chime in on the bug to let me know.

@rickeylev
Copy link
Contributor

Closing, since the other commit fixed this.

@rickeylev rickeylev closed this Oct 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants