Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

relay-socket dipose() does not send subscriptionId #16

Closed
davidye opened this issue Mar 9, 2018 · 1 comment
Closed

relay-socket dipose() does not send subscriptionId #16

davidye opened this issue Mar 9, 2018 · 1 comment

Comments

@davidye
Copy link

davidye commented Mar 9, 2018

When calling dispose(), the relay socket does not send a subscriptionId.

I tracked down the problem to this line:

cancel(absintheSocket, notifier);

When this dispose function is called, notifier.subscriptionId is still undefined.

Later on, onSubscriptionSucceed() is called and the notifier is updated with a valid subscriptionId.

const onSubscriptionSucceed = (absintheSocket, notifier, {subscriptionId}) => {

However the notifier instance passed to cancel() is not the instance that was updated, and its subscriptionId is still undefined.

@davidye
Copy link
Author

davidye commented Mar 9, 2018

Oops, this is a duplicate of #13.

@davidye davidye closed this as completed Mar 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant