Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NodeJS support #31

Closed
js2me opened this issue Mar 16, 2020 · 8 comments
Closed

NodeJS support #31

js2me opened this issue Mar 16, 2020 · 8 comments
Labels
help wanted Extra attention is needed question Further information is requested

Comments

@js2me
Copy link
Member

js2me commented Mar 16, 2020

NodeJS is not support fetch.
Needs to find a better way how to support nodejs usage generated Api module

@js2me js2me added help wanted Extra attention is needed question Further information is requested labels Mar 16, 2020
@JennieJi
Copy link
Contributor

Hi @js2me , I think it will also be a good idea to let user pass their own fetch function

@jfsiii
Copy link

jfsiii commented Oct 19, 2020

@JennieJi @js2me agreed. This way they can supply node-fetch or any fetch-compatible function

@js2me
Copy link
Member Author

js2me commented Oct 19, 2020

@jfsiii @JennieJi as simple solution for support NodeJS and own fetch function - it's customizing mustache templates

@JennieJi
Copy link
Contributor

Understood, didn't see this option, kind of unobvious

@js2me
Copy link
Member Author

js2me commented Oct 30, 2020

@JennieJi Yes, you are right, needs to update README.md

@js2me
Copy link
Member Author

js2me commented Jan 22, 2021

I think support NodeJS solution is not a good idea because it will not suitable for everyone.
And because of this, better that you will use custom ETA templates option --templates and make your own solution for your project on NodeJS.

@js2me js2me closed this as completed Jan 22, 2021
@OnkelTem
Copy link

OnkelTem commented Oct 11, 2022

I think support NodeJS solution is not a good idea because it will not suitable for everyone.

You could provide a default solution for NodeJS users instead of just ignoring them.

@jfsiii
Copy link

jfsiii commented Oct 11, 2022

NodeJS is not support fetch

This has changed since the ticket was created. Global fetch is enabled by default in node 18.

I'm not sure how this changes things for this project or this ticket, but it is an important development.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants