Bug 34250: Only listen to 'started' in noscript-control.js

This fixes a race condition which can be hit in some cases, such as running some marionette tests. The race condition results in noscript not being initialized properly due to the 'pageshow' event being received before 'started'.
acatarineu · May 18, 2020 · 8f79fdb · 8f79fdb
1 parent 36f8182
commit 8f79fdb
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/modules/noscript-control.js b/modules/noscript-control.js
@@ -146,7 +146,7 @@ var initialize = () => {
     let messageListener = (a, b, c) => {
       try {
         log(3, `Message received from NoScript: ${JSON.stringify([a, b, c])}`);
-        if (!["started", "pageshow"].includes(a.__meta.name)) {
+        if (a.__meta.name !== "started") {
           return;
         }
         Services.mm.removeMessageListener("MessageChannel:Messages", listener);