Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name-based Skill Shortcodes Refinement #22

Closed
berdandy opened this issue Mar 28, 2024 · 1 comment
Closed

Name-based Skill Shortcodes Refinement #22

berdandy opened this issue Mar 28, 2024 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@berdandy
Copy link
Member

Name-based skill shortcodes, for example:

{{ skill(name="Firestorm") }}

Can result in multiple matches. We currently display ERROR with more information for the writer to differentiate by id, but ideally, we resolve this by figuring out which variant is appropriate.

Things to check:

  • which ability is current based on profession/skill/traits/pets/etc
  • can we just pick the PvE version? how do we know which one is the PvE version?
@berdandy berdandy added bug Something isn't working enhancement New feature or request labels Mar 28, 2024
@berdandy
Copy link
Member Author

Checking PvE-ness is not possible with the API. The only option is to use the hardstuck api, or to maintain our own mapping of skill id to mode

@berdandy berdandy closed this as not planned Won't fix, can't repro, duplicate, stale May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant